up version to 0.2.1b: added absender to configuration window

Reviewed-on: #14

compile.sh

@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
-if [ $VIRTUAL_ENV=="" ]
+
+set -e
+
+if [ "$VIRTUAL_ENV" == "" ]
 then
   source venv/bin/activate
 fi
@@ -11,10 +14,11 @@ if [ "$new_version" != "" ]
 then
   echo "$new_version" | tee version.txt
 fi
-sed -i "s/VERSION = '[0-9]\.[0-9]\w'/VERSION = '$(cat version.txt)'/g" src/brovski-adress-etiketten-verwaltung.py
+sed -i "s/VERSION = '[0-9]\.[0-9].[0-9]\w'/VERSION = '$(cat version.txt)'/g" src/brovski-adress-etiketten-verwaltung.py
-sed -i "s/Version: [0-9]\.[0-9]\w/Version: $(cat version.txt)/g" deb-package/brovski-adressetiketten/DEBIAN/control
+sed -i "s/Version: [0-9]\.[0-9].[0-9]\w/Version: $(cat version.txt)/g" deb-package/brovski-adressetiketten/DEBIAN/control
 
 pyinstaller --clean --onefile src/brovski-adress-etiketten-verwaltung.py
+mkdir -p deb-package/brovski-adressetiketten/usr/local/bin
 cp dist/brovski-adress-etiketten-verwaltung deb-package/brovski-adressetiketten/usr/local/bin/brovski-adressetiketten
 dpkg-deb --build deb-package/brovski-adressetiketten
 mv deb-package/brovski-adressetiketten.deb ./

deb-package/brovski-adressetiketten/DEBIAN/control

@@ -1,5 +1,5 @@
 Package: brovski-adressetiketten
-Version: 0.1.0b
+Version: 0.2.1b
 Maintainer: Ovski
 Architecture: all
 Description: manage csv files for glables address labels

src/brovski-adress-etiketten-verwaltung.py

@@ -8,17 +8,19 @@ from tkinter import ttk
 
 from config import Config
 from model import Model
+from connector import JSONConnector
 from windows import SettingsWindow, EditRecord, show_error
 
 
 class Application:
     def __init__(self):
+        os.chdir(os.getcwd())
         # tkinter settings
         x_offset = 700
         y_offset = 200
         width = 1050
         height = 700
-        VERSION = '0.1.0b'
+        VERSION = '0.2.1b'
         title = f"Brovski Adress-Etiketten Verwaltung {VERSION}"
 
         self.root = tk.Tk(className="BrovskiAdressEtiketten")
@@ -36,7 +38,7 @@ class Application:
         self.filter_active = tk.BooleanVar(value=False)
 
         # model connector
-        self.model = Model(self.config)
+        self.model = Model(JSONConnector(self.config))
 
         # init paths to json and csv file
         self.json_file_name = "brovski-adress-etiketten-verwaltung.json"
@@ -79,7 +81,7 @@ class Application:
 
         # table content
         scrollbar = ttk.Scrollbar(data_frame, orient=tk.VERTICAL)
-        self.table = ttk.Treeview(data_frame, yscrollcommand=scrollbar.set, columns=("0", "1", "2", "3", "4"),
+        self.table = ttk.Treeview(data_frame, yscrollcommand=scrollbar.set, columns=("0", "1", "2", "3", "4", "5"),
                                   show="headings")
         scrollbar.config(command=self.table.yview)
         self.table.heading('0', text="Aktiv")
@@ -88,6 +90,7 @@ class Application:
         self.table.heading('2', text="Name")
         self.table.heading('3', text="Strasse")
         self.table.heading('4', text="Plz/Ort")
+        self.table.heading('5', text="Anzahl")
         self.table.pack(side=tk.LEFT, fill=tk.BOTH, expand=True)
         scrollbar.pack(side=tk.LEFT, fill=tk.Y)
 
@@ -138,7 +141,8 @@ class Application:
             "firma": "Firma",
             "name": "Name",
             "strasse": "Strasse",
-            "plzort": "Plz/Ort"
+            "plzort": "Plz/Ort",
+            "anzahl": "Anzahl"
         }
         self.model.create_new(values)
         self.populate_table()
@@ -227,6 +231,8 @@ class Application:
                 field = "strasse"
             case "#5":
                 field = "plzort"
+            case "#6":
+                field = "anzahl"
             case _:
                 field = "name"
 
@@ -247,6 +253,7 @@ class Application:
                 for address in self.address_list:
                     if address["aktiv"] != "x":
                         continue
+                    for index in range(int(address["anzahl"])):
                         line = []
                         if address["firma"] != "":
                             line.append(address["firma"])
@@ -254,6 +261,11 @@ class Application:
                         line.append(address["strasse"])
                         line.append(address["plzort"])
                         writer.writerow(line)
+                        # todo: add "absender" to config parameters
+                        line = []
+                        for idx in range(4):
+                            line.append(self.config.get("absender", f"{idx}"))
+                        writer.writerow(line)
         except FileNotFoundError:
             show_error(message_title="Unexpected error",
                        message=f"Could not write file {self.csv_file}",
@@ -264,6 +276,7 @@ class Application:
         if reload:
             self.address_list = self.model.get_all()
         if len(self.address_list) == 0:
+            self.delete_all_table_items()
             return
         self.delete_all_table_items()
         for address in self.address_list:
@@ -272,7 +285,7 @@ class Application:
                 continue
             self.table.insert('', 'end', iid=address["record_id"],
                               values=(address["aktiv"], address["firma"], address["name"], address["strasse"],
-                                      address["plzort"])
+                                      address["plzort"], address["anzahl"])
                               )
         self.update_status_bar()
 
@@ -289,14 +302,14 @@ class Application:
             self.table.delete(item)
 
     def open_window_settings(self):
-        window = SettingsWindow(self, self.root)
+        window = SettingsWindow(self, self.root, self.config)
         window.wm_transient(self.root)
         window.wait_visibility()
         window.grab_set()
         return window
 
     def open_window_edit_records(self, record_id: int):
-        window = EditRecord(self, self.root, record_id)
+        window = EditRecord(self, self.root, record_id, self.config)
         window.wm_transient(self.root)
         window.wait_visibility()
         window.grab_set()

src/config.py

@@ -1,12 +1,11 @@
-import configparser
 import os
-from configparser import ConfigParser, DuplicateSectionError
+from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
 
 
 class Config:
     parser: ConfigParser
 
-    def __init__(self, path: str = None, filename: str = "config.ini"):
+    def __init__(self, filename: str = "config.ini"):
         """
         Config parser reading config.ini
 
@@ -15,18 +14,12 @@ class Config:
             self.__filename: Path and name to the config file
         """
         self.parser = ConfigParser()
-        self.path = path
-        self.filename = filename
 
-        if self.path is None:
         home_path = os.environ["HOME"]
         full_path = os.path.join(home_path, ".config", "brovski-adress-etiketten" )
-        else:
-            full_path = self.path
-
         if not os.path.exists(full_path):
             os.makedirs(full_path)
-        self.config_file = os.path.join(full_path, self.filename)
+        self.config_file = os.path.join(full_path, filename)
 
         self._load()
 
@@ -42,7 +35,8 @@ class Config:
         try:
             self.parser.add_section(section)
         except DuplicateSectionError:
-            pass
+            return
+
         self._save()
 
     def set(self, section: str, option: str, value: str):
@@ -53,4 +47,10 @@ class Config:
 
     def get(self, section: str, option: str):
         self._load()
-        return self.parser.get(section, option)
+        try:
+            option = self.parser.get(section, option)
+        except NoOptionError:
+            option = ""
+        except NoSectionError:
+            option = ""
+        return option

src/connector.py

@@ -1,6 +1,7 @@
 import json
 import os
 from abc import ABC, abstractmethod
+
 from config import Config
 
 
@@ -34,14 +35,17 @@ class Connector(ABC):
 
 
 class JSONConnector(Connector):
-    def __init__(self, config: Config, ):
+    def __init__(self, config: Config):
         super().__init__(config)
         self.json_path = self.config.get("json", "path")
         self.json_file = os.path.join(self.json_path, "brovski-adress-etiketten-verwaltung-v7.json")
 
     def get_all(self) -> list:
+        try:
             with open(self.json_file, "r") as f:
                 return json.load(f)
+        except FileNotFoundError:
+            return []
 
     def get_all_sorted_by(self, field: str, reverse=False) -> list:
         with open(self.json_file, "r") as f:

src/model.py

@@ -1,9 +1,9 @@
-from connector import Connector, JSONConnector
+from connector import Connector
-from config import Config
+
 
 class Model:
-    def __init__(self, config: Config):
+    def __init__(self, connector: Connector):
-        self.connector = JSONConnector(config)
+        self.connector = connector
 
     def get_all(self):
         return self.connector.get_all()

src/windows.py

@@ -3,7 +3,7 @@ from configparser import NoSectionError, NoOptionError
 from tkinter import font, filedialog, messagebox
 
 from config import Config
-from model import Model
+from connector import JSONConnector
 
 
 def show_error(message_title: str, message: str, parent: tk.Tk | tk.Toplevel):
@@ -18,7 +18,6 @@ class Window(tk.Toplevel):
     def __init__(self, parent, root: tk.Tk):
         super().__init__(root)
         self.parent = parent
-        self.config = parent.config
         self.root = root
         self.protocol("WM_DELETE_WINDOW", self.close_window)
         self.bind("<Escape>", self.close_window)
@@ -33,11 +32,11 @@ class Window(tk.Toplevel):
 
 
 class EditRecord(Window):
-    def __init__(self, parent, root: tk.Tk, record_id: int):
+    def __init__(self, parent, root: tk.Tk, record_id: int, config: Config):
         super().__init__(parent, root)
         self.bind("<Return>", self._update)
 
-        self.model = Model(self.config)
+        self.model = JSONConnector(config)
 
         record = self.model.get_by_id(record_id)
 
@@ -49,6 +48,7 @@ class EditRecord(Window):
         self.name = tk.StringVar(value=record.get("name"))
         self.strasse = tk.StringVar(value=record.get("strasse"))
         self.plz_ort = tk.StringVar(value=record.get("plzort"))
+        self.anzahl = tk.StringVar(value=record.get("anzahl"))
 
         edit_frame = tk.Frame(self)
         edit_frame.pack(side=tk.TOP, fill=tk.X, pady=20, padx=20)
@@ -57,6 +57,7 @@ class EditRecord(Window):
         tk.Label(edit_frame, text="Name").grid(row=0, column=2)
         tk.Label(edit_frame, text="Strasse").grid(row=0, column=3)
         tk.Label(edit_frame, text="Plz/Ort").grid(row=0, column=4)
+        tk.Label(edit_frame, text="Anzahl").grid(row=0, column=5)
         edit_aktiv = tk.Checkbutton(edit_frame, variable=self.aktiv, onvalue="x", offvalue="")
         edit_aktiv.grid(row=1, column=0)
         edit_firma = tk.Entry(edit_frame, textvariable=self.firma)
@@ -67,6 +68,8 @@ class EditRecord(Window):
         edit_strasse.grid(row=1, column=3)
         edit_plz_ort = tk.Entry(edit_frame, textvariable=self.plz_ort)
         edit_plz_ort.grid(row=1, column=4)
+        edit_anzahl = tk.Entry(edit_frame, textvariable=self.anzahl)
+        edit_anzahl.grid(row=1, column=5)
 
         button_frame = tk.Frame(self)
         button_frame.pack(side=tk.TOP, pady=10)
@@ -81,26 +84,32 @@ class EditRecord(Window):
             "name": self.name.get(),
             "strasse": self.strasse.get(),
             "plzort": self.plz_ort.get(),
+            "anzahl": self.anzahl.get(),
         }
         self.model.update_record(new_record)
         self.close_window()
 
 
 class SettingsWindow(Window):
-    def __init__(self, parent, root: tk.Tk):
+    def __init__(self, parent, root: tk.Tk, config: Config):
         super().__init__(parent, root)
-        self.geometry(f"500x330+{self.root.winfo_x() + 20}+{self.root.winfo_y() + 20}")
+        width = 500
-        self.config = Config()
+        height = 630
+        self.geometry(f"{width}x{height}+{self.root.winfo_x() + 20}+{self.root.winfo_y() + 20}")
+        self.config = config
         self.json_file = tk.StringVar()
         self.csv_file = tk.StringVar()
+        self.absender_line = [tk.StringVar() for idx in range(4)]
 
         title = font.Font(family='Ubuntu Mono', size=20, weight=font.BOLD)
         tk.Label(self, text="Einstellungen", font=title).pack(pady=20)
 
-        path_frame = tk.Frame(self)
-        path_frame.pack(pady=(10, 40))
 
-        tk.Label(path_frame, text="Datenpfad JSON Datei").grid(row=0, column=0)
+        tk.Label(self, text="Datenpfad JSON Datei").pack()
+
+        path_frame = tk.Frame(self)
+        path_frame.pack(pady=(10, 10))
+
         tk.Entry(path_frame, textvariable=self.json_file, width=50).grid(row=1, column=0)
         tk.Button(path_frame, text="Pfad", command=lambda: self.set_json_path(self.json_file.get())).grid(row=1,
                                                                                                           column=1)
@@ -109,6 +118,13 @@ class SettingsWindow(Window):
         tk.Entry(path_frame, textvariable=self.csv_file, width=50).grid(row=3, column=0)
         tk.Button(path_frame, text="Pfad", command=lambda: self.set_csv_path(self.csv_file.get())).grid(row=3, column=1)
 
+        absender_frame = tk.Frame(self)
+        absender_frame.pack(pady=(10, 40))
+
+        tk.Label(absender_frame, text="Absender").pack(side=tk.TOP)
+        for idx in range(4):
+             tk.Entry(absender_frame, textvariable=self.absender_line[idx], width=50).pack(side=tk.TOP)
+
         bottom_frame = tk.Frame(self)
         bottom_frame.pack()
         tk.Button(bottom_frame, text="Ok", command=self.ok).pack(side=tk.LEFT)
@@ -145,6 +161,15 @@ class SettingsWindow(Window):
         except NoOptionError:
             self.config.set("csv", "path", "")
 
+        for idx in range(4):
+            try:
+                self.absender_line[idx].set(self.config.get(f"absender", f"{idx}"))
+            except NoSectionError:
+                self.config.add_section(f"line")
+                self.config.set("line", f"{idx}", "")
+            except NoOptionError:
+                self.config.set("line", f"{idx}", "")
+
     def ok(self):
         if self.json_file.get() == "" or self.csv_file.get() == "":
             show_error(message_title="Fehlerhafte Konfiguration",
@@ -153,6 +178,8 @@ class SettingsWindow(Window):
             return
         self.config.set("json", "path", self.json_file.get())
         self.config.set("csv", "path", self.csv_file.get())
+        for i in range(4):
+            self.config.set("absender", f"{i}", f"{self.absender_line[i].get()}")
         self.close_window()
 
     def cancel(self):

tests/test_config.py

@@ -1,30 +0,0 @@
-import os
-from typing import assert_type
-
-import pytest
-
-from src.config import Config
-
-
-@pytest.fixture
-def config() -> Config:
-    config = Config(path="testfiles", filename="configtest.ini")
-    return config
-
-def teardown_config():
-    print("tearing down config test")
-
-def test_construction(config):
-    assert_type(config, Config)
-
-def test_file_creation(config):
-    config._save()
-    assert os.path.isfile(os.path.join(config.path, config.filename))
-
-def test_add_section(config):
-    config.add_section("test_section")
-    assert "test_section" in config.parser.sections()
-
-def test_set_and_get(config):
-    config.set(section="section", option="option", value="value")
-    assert config.get(section="section", option="option") == "value"

version.txt

@@ -1 +1 @@
-0.1.0b
+0.2.1b